Ticket Hash: | 48a672ff69bf7f5d02dfce716ae9983b108a64d9 | |||
Title: | iPad keyboard only sends 1 letter with jsmpeg driver | |||
Status: | Closed | Type: | Code_Defect | |
Severity: | Minor | Priority: | Medium | |
Subsystem: | Resolution: | Fixed | ||
Last Modified: | 2019-12-02 14:35:19 | |||
Version Found In: | ||||
User Comments: | ||||
john added on 2019-10-04 11:06:50:
(text/x-fossil-plain)
This applies only with jsmpeg app usage. 1 - Using a keyboard from a desktop computer, everything is ok. 2 - Using a keyboard from an Android tablet, the contents of the keyboard is sent when you press the -> on screen key, and so everything is ok. 3 - But when using the on-screen keyboard on iPad, only the first character is sent. This is likely a bug with jsmpeg. On iOS, I have reproduced this bug with Chrome, Safari, Brave. I've made a short video demonstrating the problem: https://youtu.be/edR3lNi8zDM chw added on 2019-10-04 16:13:34: (text/x-fossil-plain) Nothing I can do on this since I have no iPad for testing. However, please try out changing the "macLike" variable in .../SDL2/src/video/jsmpeg/data/jsmpg-vnc.js to not contain the "iPhone|iPod|iPad" strings in the regexp. Maybe this helps. john added on 2019-10-11 10:53:21: (text/x-fossil-plain) Am I correct in understanding that I need to build my own Androwish in order to test this suggestion, as the file you suggest editing is bundled inside it. Is that right? chw added on 2019-10-11 11:57:16: (text/x-fossil-plain) Yes and/or no. The quickest result is to use a hex editor of your choice, search for "iPod" which should give exactly one hit (for the windows binaries, MacOS not verified) and then edit the regexp from "iPhone|iPod|iPad" to e.g. "yPhone|yPod|yPad" or another letter of choice. Perform this on the undroidwish.exe or the undroidwish binary contained in the MacOS .dmg. And, yes, code signing is for wimps, indeed ;-) john added on 2019-11-13 12:13:43: (text/x-fossil-plain) I did the HEX edit as you suggested, but did not perceive a difference in functionality. A few people have made Wish-based virtual keyboards, such as: https://wiki.tcl-lang.org/page/Keyboard+widget and that seems like the obvious work-around. Though, I presume that since this bug in someone else's Javascript code (you didn't write it) it's also possible that a later version of their code will fix this minor problem. chw added on 2019-11-13 21:04:34: (text/x-fossil-plain) Meanwhile I was able to reproduce the problem with Safari on a Macbook. A possible fix is in check-in [2e89a99e47]. Please check this with the updated undroidwishes which are ready for download in the usual location. john added on 2019-12-02 12:50:51: (text/x-markdown) I confirm that your latest OSX build of undroidwish, fixes this bug. I was able to correctly type from my iPad. Thanks! chw added on 2019-12-02 14:35:19: (text/x-markdown) Fine, closing this ticket now. |